fix: swap out @npmcli/ci-detect for ci-info
#667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
added
bug
weird nock behavior, not sure what's going on
erunion
approved these changes
Nov 14, 2022
| @@ -76,7 +76,6 @@ | |||
| "@types/jsonpath": "^0.2.0", | |||
| "@types/mime-types": "^2.1.1", | |||
| "@types/node-fetch": "^2.6.2", | |||
| "@types/npmcli__ci-detect": "^2.0.0", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
I opened npm/ci-detect#47 to address this, but per #664 it looks like our CI detection has some imperfections.
ci-infoseems to be more popular and well-maintained. We looked at this package ages ago but I was initially hesitant because it is a bit annoying to write tests with it but I got that figured out.Update: it looks like the npm CLI team is planning on deprecating their package in favor of
ci-info, so we should probably do this anyways.🧬 QA & Testing
No material changes here except perhaps better CI detection. Do tests pass?