fix: npm script awareness, TS fixes, test env refactors #659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
rdme
in their deps... so this PR installskeyv
and it evidently fixes it1 🤷🏽 31c6700npm_lifecycle_event
to indicate the currentnpm run
script. This feels like a good place to not have our GitHub Action onboarding prompts run 🙅🏽 09cdbf2TEST_RDME_
NODE_ENV
for our tests fromtest
tordme-test
isTest
helper to check whether we're running tests🧬 QA & Testing
I
npm link
'd this PR to our Metrics API codebase and rannpm run build
in that codebase and confirmed that:If our test bed passes, we should be good to go 🥳
Footnotes
See: https://stackoverflow.com/q/74141618 ↩