-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: v8 docs #637
Merged
kanadgupta
merged 43 commits into
main
from
kanad/rm-5536-update-docs-in-github-repo-and-knowledge
Oct 31, 2022
Merged
docs: v8 docs #637
kanadgupta
merged 43 commits into
main
from
kanad/rm-5536-update-docs-in-github-repo-and-knowledge
Oct 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
reviewed
Oct 12, 2022
Co-Authored-By: Jon Ursenbach <[email protected]>
kanadgupta
requested review from
erunion,
darrenyong,
rafegoldberg,
RyanGWU82 and
a team
and removed request for
a team
October 17, 2022 23:45
kanadgupta
commented
Oct 17, 2022
RyanGWU82
approved these changes
Oct 18, 2022
CircleCI code sample source: https://circleci.com/blog/next-testing/ CircleCI config reference: https://circleci.com/docs/configuration-reference/ Travis CI lifecycle reference: https://docs.travis-ci.com/user/job-lifecycle/ Travis CI Node.js reference: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#specifying-nodejs-versions Co-Authored-By: Ryan Park <[email protected]>
also rearranged the installation steps so global installation is first Co-Authored-By: Ryan Park <[email protected]>
erunion
reviewed
Oct 18, 2022
Co-Authored-By: Jon Ursenbach <[email protected]>
Co-Authored-By: Jon Ursenbach <[email protected]>
erunion
approved these changes
Oct 18, 2022
thanks i hate it s/o https://github.com/jonschlinkert/markdown-toc
per feedback from spang
per feedback from spang
per feedback from marketing sync
per feedback from spang
have i mentioned how i hate manually updated TOCs
kanadgupta
deleted the
kanad/rm-5536-update-docs-in-github-repo-and-knowledge
branch
October 31, 2022 15:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Goals
--github
flag, but provide documentation on manual setup if users need it 🧠login
command sucks less now) 🌏rdme
can be used without a ReadMe account (i.e., for reducing/validating OAS) ✨🧬 QA & Testing
Do the docs achieve the above goals? And are they free of any grammar/mechanical issues?