Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): use correct _id param #616

Merged
merged 1 commit into from
Sep 20, 2022
Merged

fix(docs): use correct _id param #616

merged 1 commit into from
Sep 20, 2022

Conversation

kanadgupta
Copy link
Member

🧰 Changes

We render the doc ID in the success response for the docs/changelogs/custompages commands. Issue is that we were using res.id when we should be using res._id, since only the latter actually shows up for Changelog and Custom Pages.

🧬 QA & Testing

Do tests pass?

@kanadgupta kanadgupta added bug Something isn't working command:docs Issues pertaining to the `docs`, `changelogs`, or `custompages` commands labels Sep 20, 2022
@kanadgupta kanadgupta marked this pull request as ready for review September 20, 2022 18:35
@kanadgupta kanadgupta merged commit 7175537 into main Sep 20, 2022
@kanadgupta kanadgupta deleted the fix/use-correct-id-param branch September 20, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenyong darrenyong Awaiting requested review from darrenyong

@Dashron Dashron Awaiting requested review from Dashron

Assignees
No one assigned
Labels
bug Something isn't working command:docs Issues pertaining to the `docs`, `changelogs`, or `custompages` commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kanadgupta