-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(testbed): jest 29, flakiness fixes #610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is probably a typo in the docs but this is what I see in every example: https://kulshekhar.github.io/ts-jest/docs/getting-started/options/tsconfig#path-to-a-tsconfig-file
also rename setup file accordingly
kanadgupta
added
bug
Something isn't working
refactor
Issues about tackling technical debt
labels
Sep 29, 2022
kanadgupta
changed the title
chore(deps-dev): jest 29
chore(testbed): jest 29, flakiness fixes
Sep 29, 2022
erunion
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glad you were able to finally sort this out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
refactor
Issues about tackling technical debt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This PR bumps Jest and handles a bunch of testbed housekeeping. Not sure if tests are faster1, but the flakiness when running them locally should be gone.
jest
,ts-jest
, and@types/jest
to v292 and updated snapshots accordingly (see their blog post) 🆙 📸NODE_ENV
value totesting
for our testing environment as opposed to the widely usedNODE_ENV
value oftest
, so this makes that long overdue change. We were able to make a slight cleanup to our setup file as a result. 🧹configstore
has continued to give us grief when running tests locally and I had the idea of including theJEST_WORKER_ID
in ourconfigstore
paths so Jest workers aren't clashing with each other. Now the test bed is editing a few of config files (7 on my local machine) instead of just one. That tiny change completely solved the flakiness on my local machine ✨Sadly, our Jest coverage issues in CI (see #617) continue to persist 😭
🧬 QA & Testing
Do tests pass? And do they always pass?
Footnotes
I mean... tests do feel faster? But maybe that's just a placebo ¯_(ツ)_/¯ ↩
We were struggling to upgrade to Jest 29 for a few weeks now since our
__tests__/tsconfig.json
file wasn't being read properly. After noodling on this for a bit, I discovered that bumping us down to the legacyts-jest
preset fixed everything :cryparty: I don't love this solution but hopefully it's temporary. ↩