feat(breaking/version): raw versions only, usage cleanup #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
added
enhancement
erunion
reviewed
Sep 12, 2022
| @@ -6,6 +6,10 @@ import configStore from '../../src/lib/configstore'; | |||
| const cmd = new Command(); | |||
|
|
|||
| describe('rdme logout', () => { | |||
| afterEach(() => { | |||
| configStore.clear(); | |||
There was a problem hiding this comment.
Oh is us not clearing this out why sometimes the login test flakes out?
There was a problem hiding this comment.
I think so 😬 the test bed seems a little flakier now that I added so many tests messing with configstore so I'm hoping this addresses that
erunion
reviewed
Sep 12, 2022
| @@ -152,17 +152,19 @@ export default class Command { | |||
| { | |||
| name: 'main', | |||
| type: String, | |||
| description: 'Should this version be the primary (default) version for your project?', | |||
| description: | |||
| "Should this version be the primary (default) version for your project? (Must be 'true' or 'false')", | |||
There was a problem hiding this comment.
Adding so much boilerplate into the help screens for "must be true or false" seems like a lot.
There was a problem hiding this comment.
yeah I don't love this but not sure if it's clear otherwise since the user is just supposed to pass in a string. ideally this should be a boolean but I've given these commands more love than they already deserve lol
erunion
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
versionscommand and removes all logic/deps pertaining to table generationversions:updatecommand now accepts theversionparameter as the default option (rather than via a--versionflag) so the usage is consistent withversions:createandversions:deleteversionscommandsconfigstorefor tests that interact with itVersiontype (i.e. the version object that isPOST-ed and received from our API) and uses it throughout the codebase where applicable.🧬 QA & Testing
Do the docs changes look good? And do tests pass?