feat(docs): Add id to success message response for docs and docs:single
#583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
added
enhancement
kanadgupta
requested changes
Aug 29, 2022
There was a problem hiding this comment.
Thanks for the PR @garrett-wade—this change makes a lot of sense! One small copy suggestion below, otherwise LGTM!
Co-authored-by: Kanad Gupta <[email protected]>
erunion
previously requested changes
Aug 31, 2022
There was a problem hiding this comment.
can you take a look at the tests again here @garrett-wade? looks like they're all failing with that message change.
|
Thanks @garrett-wade! |
kanadgupta
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Added the id of a document to the success response when a document is uploaded. We often have developer publishing a single doc that will be used as the parent for another doc, and getting the id directly in the response improves the experience for the developer.
🧬 QA & Testing
Run the
docs:singleordocscommand on a file you wish to upload.Notice the id is added to the success message(s) printed in the console.