Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: optimize test runs and add docs syncing dry run #565

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Aug 10, 2022

🧰 Changes

  • Makes some tiny optimizations our CI workflow on events so we're not running our CI twice for every push in a PR.
  • Performs a dry run of our docs syncing workflow on every push. This is so we can avoid what happened yesterday in this workflow where our sync failed but we didn't realize it was merged into main.

🧬 QA & Testing

Are tests still running on every push to the PR, but with fewer duplicate workflow runs? And is the docs syncing workflow running as expected and properly skipping over the actual syncing step?

We had a lot of duplicate test runs, this optimizes that
@kanadgupta kanadgupta changed the title ci: optimize test runs ci: optimize test runs and add docs syncing dry run Aug 10, 2022
@kanadgupta kanadgupta added the refactor Issues about tackling technical debt label Aug 10, 2022
@kanadgupta kanadgupta requested a review from erunion August 10, 2022 21:05
@kanadgupta kanadgupta marked this pull request as ready for review August 10, 2022 21:05
push:
branches:
- main
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this get fired for every push to a pull request or just when one's created?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both! Here's a snippet of the default pull_request behavior from these docs:

By default, a workflow only runs when a pull_request event's activity type is opened, synchronize, or reopened.

As the name implies, the opened activity type is for whenever a PR is opened.

Here's a description of synchronize from these docs:

Triggered when a pull request's head branch is updated. For example, when the head branch is updated from the base branch, when new commits are pushed to the head branch, or when the base branch is changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues about tackling technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants