Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files ending in .markdown don't sync properly #546

Closed
kanadgupta opened this issue Jul 28, 2022 · 0 comments
Closed

Files ending in .markdown don't sync properly #546

kanadgupta opened this issue Jul 28, 2022 · 0 comments
Labels
bug Something isn't working command:docs Issues pertaining to the `docs`, `changelogs`, or `custompages` commands good first issue Good for newcomers
Milestone
v7.5

Comments

@kanadgupta
Copy link
Member

These lines are wrong:

rdme/src/cmds/docs/single.js

Line 54 in fe24984

if (filePath.endsWith('.md') === false || !filePath.endsWith('.markdown') === false) {

rdme/src/cmds/changelogs/single.js

Line 48 in fe24984

if (filePath.endsWith('.md') === false || !filePath.endsWith('.markdown') === false) {

We should fix this and add a test to check for these files.
@kanadgupta kanadgupta added bug Something isn't working good first issue Good for newcomers command:docs Issues pertaining to the `docs`, `changelogs`, or `custompages` commands labels Jul 28, 2022
@kanadgupta kanadgupta added this to the v7.5 milestone Jul 28, 2022
@kanadgupta kanadgupta mentioned this issue Jul 28, 2022
Merged
@r0hack r0hack mentioned this issue Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working command:docs Issues pertaining to the `docs`, `changelogs`, or `custompages` commands good first issue Good for newcomers
Projects
None yet
Milestone
v7.5
Development

No branches or pull requests
1 participant
@kanadgupta