refactor: rename category to cmdCategory in Command class
#544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When debugging this, I found it useful to throw some more console logs in this file, but ESLint should flag anything that's not those three lines
erunion
approved these changes
Jul 26, 2022
kanadgupta
deleted the
kanad/rm-4913-refactor-field-in-rdme-command-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Per feedback from Jon, renames a field our
Commandclass fromcategorytocmdCategory. It's a bit confusing given the "category" terminology in the ReadMe andrdmeecosystem.Also made a tiny ESLint disable change in our
bin/rdmefile—see 3fbf38f for the reasoning.🧬 QA & Testing
I ran any commands that I think would be affected (e.g.
bin/rdme,bin/rdme openapi --help, etc.) and tests are passing now... our test suite is pretty comprehensive so I can't think of anything else that would break, but fingers crossed 😬