feat(help): typos, add rdme version
#493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means I had to remove some snapshot tests in favor of partial match testing... feels bad but don't really know how to test dynamic things like versions via snapshots 😭
kanadgupta
requested review from
a team,
erunion,
kellyjosephprice and
emilyskuo
and removed request for
a team
kellyjosephprice
approved these changes
Apr 14, 2022
erunion
approved these changes
Apr 14, 2022
| @@ -9,7 +9,7 @@ describe('bin', () => { | |||
|
|
|||
| await new Promise(done => { | |||
| exec(`node ${__dirname}/../bin/rdme`, (error, stdout) => { | |||
| expect(stdout).toContain('a utlity for interacting with ReadMe'); | |||
| expect(stdout).toContain('a utility for interacting with ReadMe'); | |||
There was a problem hiding this comment.
problem is that the snapshot contains the package version, and we'd have to update the snapshot for every bump and I couldn't think of an easy way to get around that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
lol... just discovered we spell "utility" wrong in the main help screen 😮💨
This fixes that, and also adds the current
rdmeversion to the help screen:🧬 QA & Testing
Unfortunately this means I had to rip out a snapshot test in favor of a partial test, but if tests pass and the copy looks good, we should be good to go!