-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add workdir arg to openapi command #450
Conversation
This PR refers to this issue comment on https://github.com/readmeio/github-readme-sync |
Thanks for the PR @jdecool! Could you add a test case for this? Along with an OpenAPI definition example that uses relative references? You can see a similar example here: rdme/__tests__/cmds/openapi.test.js Lines 256 to 283 in e36c610
|
Thanks for your answer @kanadgupta and for your explanation. I've just updated the PR with a test case. |
Thanks for the test @jdecool! Could you also add this parameter to the |
Sure. Done in the last commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jdecool!
🧰 Changes
We use a monorepo structure to manage our projects and our OpenAPI specification contains relative references to external models.
So when running
rdme
on our repository, we need to specify the current working directory to handle those relative paths.This PR adds an optional
workdir
parameter to theopenapi
command.🧬 QA & Testing
To test it, you have to run the
openapi
command using the--workdir=path
.So all file should be relative to the specified
path
.