Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: tweak ESLint config, small refactors #422

Merged
merged 2 commits into from
Jan 8, 2022
Merged

ci: tweak ESLint config, small refactors #422

merged 2 commits into from
Jan 8, 2022

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Jan 7, 2022 •
edited
Loading

🧰 Changes

  • Updates our ESLint config to add warnings when we attempt to use console.log() statements (and added an explanatory comment
  • Slight refactors to bin/rdme to make it a bit more readable.

🧬 QA & Testing

Does CI pass with no warnings?

EDIT: yes

@kanadgupta kanadgupta requested a review from erunion January 8, 2022 00:00
@kanadgupta kanadgupta added documentation Improvements or additions to documentation refactor Issues about tackling technical debt labels Jan 8, 2022
@kanadgupta kanadgupta merged commit f842480 into main Jan 8, 2022
@kanadgupta kanadgupta deleted the refactor/eslint branch January 8, 2022 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion erunion approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation refactor Issues about tackling technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanadgupta @erunion