fix: allow customers to define the slug in the metadata #375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Coinbase was running into an issue where pages were getting new slugs instead of updating the existing ones. They added a
slug
field in their metadata in the markdown files, which it seems like we didn't officially support. Since we were using the file name to generate the slug when seeing if a doc existed or not, but still created the page with the slug they defined it was ending up in a weird state where pages were being created on every sync.🧬 QA & Testing
If you want to test locally you can run the following:
This will update the page here: https://dash.readme.com/project/PROJECT/v1.0/docs/new-page