Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds pagination to the OpenAPI command #353

Merged
merged 3 commits into from
Aug 20, 2021
Merged

feat: Adds pagination to the OpenAPI command #353

merged 3 commits into from
Aug 20, 2021

Conversation

rahulhegdee
Copy link
Contributor

🧰 Changes

  • Adds pagination to the OpenAPI command when updating a spec.

🧬 QA & Testing

  • make sure tests pass.
  • make sure pagination design looks good!
  • make sure OpenAPI command works as expected.

Screen Shot 2021-08-20 at 12 38 50 PM

@erunion erunion added the enhancement New feature or request label Aug 20, 2021
@erunion erunion changed the title Feat: Adds pagination to the OpenAPI command feat: Adds pagination to the OpenAPI command Aug 20, 2021
erunion
erunion approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

havent tested it out myself but all the code looks solid

erunion
erunion reviewed Aug 20, 2021
View reviewed changes
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and works great!

@erunion erunion merged commit fb6ec65 into main Aug 20, 2021
@erunion erunion deleted the rdme-ux-cannot-arrow-down-to-update-more-cx-511 branch August 20, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion erunion approved these changes

@rafegoldberg rafegoldberg Awaiting requested review from rafegoldberg

@kanadgupta kanadgupta Awaiting requested review from kanadgupta

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulhegdee @erunion