Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add $ref bundling to OpenAPI/Swagger command #342

Merged
merged 4 commits into from
Jul 27, 2021
Merged

feat: add $ref bundling to OpenAPI/Swagger command #342

merged 4 commits into from
Jul 27, 2021

Conversation

rahulhegdee
Copy link
Contributor

@rahulhegdee rahulhegdee commented Jul 27, 2021 •
edited
Loading

🧰 Changes

Adds $ref bundling to the OpenAPI command so that all the references we need are inserted into the file we're bundling to.
Adds support for uploading OpenAPI files with remote and url reference pointers.

On Main:
Screen Shot 2021-07-26 at 5 46 53 PM

With this PR:
Screen Shot 2021-07-26 at 5 47 18 PM

🧬 QA & Testing

  • Make sure that OpenAPI files with remote references are uploaded properly.

@rahulhegdee rahulhegdee requested a review from erunion July 27, 2021 01:12
@erunion erunion added the enhancement New feature or request label Jul 27, 2021
@rahulhegdee rahulhegdee changed the title feat: add $ref bundling to docs command feat: add $ref bundling to OpenAPI/Swagger command Jul 27, 2021
erunion
erunion requested changes Jul 27, 2021
View reviewed changes
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this to make sure that what's being bundled and sent to the API is what we want?

erunion
erunion reviewed Jul 27, 2021
View reviewed changes
__tests__/cmds/openapi.test.js Outdated Show resolved Hide resolved
src/cmds/openapi.js Outdated Show resolved Hide resolved
@rahulhegdee rahulhegdee requested a review from erunion July 27, 2021 19:24
@erunion erunion merged commit af3c7c2 into main Jul 27, 2021
@erunion erunion deleted the bring-back-ref-bundling-for-oasswagger-rm-1207 branch July 27, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion erunion approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulhegdee @erunion