Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: command position sorting within the help screen #341

Merged
merged 1 commit into from
Jul 23, 2021
Merged

fix: command position sorting within the help screen #341

merged 1 commit into from
Jul 23, 2021

Conversation

erunion
Copy link
Member

@erunion erunion commented Jul 21, 2021

🧰 Changes

This fixes some improper Array.sort() logic within the help screen where the position properties that each command emits weren't being properly utilized.

🧬 QA & Testing

Before:

Screen Shot 2021-07-20 at 11 20 17 PM

After:

Screen Shot 2021-07-20 at 11 20 25 PM

@erunion erunion added the bug Something isn't working label Jul 21, 2021
@erunion erunion requested review from julshotal and rahulhegdee July 21, 2021 06:22
rahulhegdee
rahulhegdee approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@rahulhegdee rahulhegdee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@erunion erunion merged commit 14e26d4 into main Jul 23, 2021
@erunion erunion deleted the fix/command-help-positioning branch July 23, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulhegdee rahulhegdee rahulhegdee approved these changes

@julshotal julshotal Awaiting requested review from julshotal

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erunion @rahulhegdee