Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Issues with lodash in CJS #244

Closed
kanadgupta opened this issue Sep 21, 2023 · 0 comments · Fixed by #245, #247 or #248
Closed

Issues with lodash in CJS #244

kanadgupta opened this issue Sep 21, 2023 · 0 comments · Fixed by #245, #247 or #248
Labels
bug Something isn't working

Comments

@kanadgupta
Copy link
Member

kanadgupta commented Sep 21, 2023

I was able to get this package working in ESM thanks to the fix in #242 and #243, but now it appears we're seeing the converse issue in CJS builds 😭

image

A few possible ideas for solutions:

  • It's possible that the fix in fix: don't use module #243 was the actual reason why this package wasn't working in ESM — we could maybe revert refactor: use lodash-es over lodash #242 entirely?
  • Try loading in the specific paths or packages (e.g., import lodashGet from 'lodash/get', import lodashGet from 'lodash.get)'
  • My personal favorite — ideally we get rid of lodash entirely? This package is loaded in the @api/core package so if we can avoid loading in lodash (and ideally qs) as an upstream dep, that'd be preferred.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
1 participant