feat: rewriting the library in typescript #210
Conversation
| @@ -12815,17 +12815,3 @@ Object { | |||
| ], | |||
| } | |||
| `; | |||
|
|
|||
| exports[`#validate should colorize errors when \`opts.colorizeErrors\` is present 1`] = ` | |||
There was a problem hiding this comment.
This got removed because we're skipping this test and Jest didn't carry it over when it moved the snapshot. If we ever re-enable this test this snapshot will come back then.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } else if (typeof obj === 'object') { | ||
| return 'json'; | ||
| } else if (typeof obj === 'string') { | ||
| if (obj.match(/\s*{/)) { |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
Co-authored-by: Kanad Gupta <[email protected]>
There was a problem hiding this comment.
Small nit, I just realized we run the tsc build twice in CI. Once here:
oas-normalize/.github/workflows/ci.yml
Line 22 in d739429
And once here, in the test script:
Line 40 in d739429
Will defer to you on which one to keep!
|
Removed the |
🧰 Changes
I've rewritten this library in TypeScript. I also pulled in our
jsdocstandards from@readme/eslint-configso all methods in the library now have more accessible docs (along with the new TS types that are available).That's it!