-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternate background colors for lines #39
Comments
Related: https://twitter.com/Bunker_D_/status/994921740039008256 (sorry, tweet in French) But you can test the Chrome or Firefox extension. Unfortunately, I could neither find a repo nor an account so it’s difficult to get insights about this particular feature and its implementation. Help from @garconvacher to contact the creator of this extension, maybe? |
Oops... I didn't see your request for help before :-/ |
Thanks @garconvacher 🙏 |
Did a super quick test with lining.js and results are obviously a lot better since each line is wrapped in a As you can see, works with pagination. The main caveat though is that you have to modify the DOM and this can possibly screw the CSS cascade + it takes some time to update when resizing the window – it’s pretty visible, I’d say it’s feeling like 1 second or so. |
(Found this tweet from the developer of the DysAide extension. I send him a PM on Twitter with a link to this thread :) ) |
Also, modifying the DOM potentially breaks existing CFI references that are used internally to record bookmarks / annotations. In Readium "1" there is a mechanism / API to blacklist DOM fragments during CFI "processing" (i.e. when a CFI expression is generated from a DOM location / range, and when a DOM location / range is resolved from a CFI expression). If I remember correctly, blacklisted DOM fragments are effectively ignored from the root down (in their entirety), in other words it is not possible to "skip" intermediary wrapping elements such as In Readium2 there is currently no such mechanism at all, ... but then there is no real support for CFI either, yet ;) That being said, |
So, DysAide extension is now Aidodys Free due to a partnership with the Aidodys company. |
This has been resolved during today’s engineering call. Here are the notes:
So this is out of scope for Readium CSS, and should be handled programmatically. |
Instead of closing this issue, could we move it to the architecture repo? I think that all of these discussions are still relevant to our project. |
Ah so I can reopen the issue but not transfer it via the built-in feature. But someone being an admin in both the ReadiumCSS and Architecture repos should be able to do so. |
Issue moved to readium/architecture #114 via ZenHub |
This will be part of the experimental features we may ship in the beta release.
A pure CSS solution has some drawbacks, as demonstrated in issue 18:
line-height
(paragraphs);linear-gradient
is quite heavy, CSS-wise.Possible alternative is something like lining.js, which might bring support to the paged view – right now, I can’t tell.
The text was updated successfully, but these errors were encountered: