Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.76] Do not stub SoLoader and revert com.facebook.common.logging.FLog breaking change #486

Closed
cortinico opened this issue Sep 12, 2024 · 1 comment
Assignees
Labels
Type Pick Request Pick requests to include commits inside a React Native release

Comments

@cortinico
Copy link
Collaborator

cortinico commented Sep 12, 2024

Target Branch(es)

0.76

Link to commit or PR to be picked

In order top to bottom
facebook/react-native@81e8c39
facebook/react-native@d7c1e5b
facebook/react-native@2136c19

Description

Folks at SWM mentioned that Native Library merging caused a breaking change on com.facebook.common.logging.FLog (being removed).

This was caused by the current implementation which relies on stubbing of SoLoader. I had to break the api/implementation dependency of Fresco, as otherwise libraries would re-import SoLoader.

I've worked with the SoLoader team to release v0.12.0 which adds native support for Native Library Merging, so this breaking change is no longer needed.

There is also a change in the template that is needed:

@cortinico cortinico added the Type Pick Request Pick requests to include commits inside a React Native release label Sep 12, 2024
@cortinico cortinico moved this from Inbox to Triaged in React Native 0.76 Releases Sep 16, 2024
@cortinico cortinico self-assigned this Sep 16, 2024
@cortinico cortinico moved this from Triaged to Done / Picked in React Native 0.76 Releases Sep 16, 2024
@cortinico cortinico closed this as completed by moving to Done / Picked in React Native 0.76 Releases Sep 16, 2024
@cortinico
Copy link
Collaborator Author

Picked, will land in 0.76.0 RC1 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type Pick Request Pick requests to include commits inside a React Native release
Projects
Status: Done / Picked
Development

No branches or pull requests

1 participant