Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.74] fix: add missing fields to native errors in new arch #199

Closed
cipolleschi opened this issue Apr 5, 2024 · 1 comment
Closed

[0.74] fix: add missing fields to native errors in new arch #199

cipolleschi opened this issue Apr 5, 2024 · 1 comment
Assignees

Comments

@cipolleschi
Copy link
Collaborator

cipolleschi commented Apr 5, 2024

Target Branch(es)

0.74

Link to commit or PR to be picked

facebook/react-native@98b1331

Description

With 0.74.rc-5 one bug which related to errors was fixed (facebook/react-native#41950). However, the fix introduced another one: the shape of Error objects that come from native modules has changed. This PR attempts to fix that, though it's not (yet) doing it in a way that would be 100% compatible with the old arch.

The problem was observed on iOS, not sure what the situation is on Android but believe it's okay there.

See facebook/react-native#43649 for more details

@cortinico
Copy link
Collaborator

✅ Picked, this will land in 0.74 RC7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done / Picked
Development

No branches or pull requests

2 participants