Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.74][Android] reload() support in ReactDelegate in order to fix react-native-restart #169

Closed
arushikesarwani94 opened this issue Mar 21, 2024 · 0 comments
Assignees

Comments

@arushikesarwani94
Copy link
Collaborator

arushikesarwani94 commented Mar 21, 2024

Target Branch(es)

0.74

Link to commit or PR to be picked

facebook/react-native#43521
facebook/react-native#43588

Description

This is part of backwards compatibility layers to fix react-native-restart in Bridgeless

Exposing reload() in ReactDelegate that takes care of selecting the appropriate DevSupportManager depending on the architecture in use to handle reload.

https://github.com/avishayil/react-native-restart/blob/134cabd5b3f355ffe551e5dd1be1dd46d870fe13/android/src/main/java/com/reactnativerestart/RestartModule.java#L54

can now be :

if(currentActivity instanceOf ReactActivity) {
    ReactActivity reactActivity = (ReactActivity) currentActivity;
    ReactDelegate reactDelegate = reactActivity.getReactDelegate();
    reactDelegate.reload()
}

Commits to Be Picked :

facebook/react-native@d5d55bf
facebook/react-native@7adc962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done / Picked
Development

No branches or pull requests

1 participant