Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.74] Umbrella issue for Expo-specific debugger picks #128

Closed
4 tasks done
motiz88 opened this issue Mar 7, 2024 · 7 comments
Closed
4 tasks done

[0.74] Umbrella issue for Expo-specific debugger picks #128

motiz88 opened this issue Mar 7, 2024 · 7 comments
Assignees

Comments

@motiz88
Copy link
Collaborator

motiz88 commented Mar 7, 2024

@byCedric is working on a number of PRs to React Native to keep Expo's debugger integration working in 0.74, following changes to implementation details that Expo was previously relying on.

This includes the following PRs (more could be added)

This is an umbrella issue to track this work for 0.74.

NOTE: Beyond just fixing 0.74, the PRs are designed to prevent future breakages from making it to RC.

@byCedric
Copy link

byCedric commented Mar 7, 2024

There is 1 PR more, that unblocks our tunnel/lan/local mode when starting Metro: facebook/react-native#43307

@cortinico
Copy link
Collaborator

We're going to do RC3 on Monday 11th at 10AM GMT.
Which of those PRs should be included? I assume only facebook/react-native#43310 for now?

@byCedric
Copy link

byCedric commented Mar 8, 2024

All PRs, except that one, are awaiting review. I'm not sure which one we can merge before the 11th. @cortinico

@cortinico
Copy link
Collaborator

All PRs, except that one, are awaiting review. I'm not sure which one we can merge before the 11th. @cortinico

Got it 👍 I'm more wondering if those PRs are meaningful in isolation or they need to be picked all together. If they're isolated, on Monday we'll just pick what we have available in main 👍

@byCedric
Copy link

byCedric commented Mar 8, 2024

The only meaningful one is the API addition: facebook/react-native#43291

The others are small bug fixes and can be done in isolation. We can work around those issues if we know they haven't been merged yet. Eventually we shouldn't have to work around these though, but that's for a time when everything is merged.

@cortinico
Copy link
Collaborator

cortinico commented Mar 11, 2024

We're picking:

into the release branch. Will be released in RC3

@huntie
Copy link
Member

huntie commented Mar 18, 2024

All changes picked (will be 0.74 RC4) ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done / Picked
Development

No branches or pull requests

4 participants