Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remoteAddress property not part of PSR-7 #153

Closed
maciejmrozinski opened this issue Mar 30, 2017 · 4 comments
Closed

remoteAddress property not part of PSR-7 #153

maciejmrozinski opened this issue Mar 30, 2017 · 4 comments
Labels
Milestone

Comments

@maciejmrozinski
Copy link

Hi,

Just a quick thought about remoteAddress property which is added to every request object. Shouldn't we add it through withAttribute method? This will be compatible with PSR7, right now it doesn't look that way https://github.com/reactphp/http/blob/master/src/Server.php#L235

@clue clue added this to the v0.7.0 milestone Mar 30, 2017
@clue clue added the bug label Mar 30, 2017
@clue
Copy link
Member

clue commented Mar 30, 2017

Thanks for spotting and reporting this @maciejmrozinski!

This is something we're aware of and I hear this is something @legionth is currently working on as part of #28 :-) Note that this isn't "incompatible" per se, it's just not part of PSR7 and the server params or attributes would be better suited for this 👍

Refs #146, so this only affects the current master branch and has not (and will not) end up in any releases.

@maciejmrozinski
Copy link
Author

@clue You're right. "Incompatible" is too strong word for this situation. Waiting to see it changed by @legionth then :) thx

@clue clue changed the title remoteAddress property incompatible with PSR7 remoteAddress property not part of PSR-7 Mar 31, 2017
@ssipos90
Copy link

ssipos90 commented Apr 2, 2017

@maciejmrozinski, that class can implement and extend anything, as long as it respects the psr interface.

@maciejmrozinski
Copy link
Author

Resolved in #160 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants