Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Expect: 100 continue #94

Closed
nick4fake opened this issue Jun 7, 2017 · 2 comments
Closed

Support for Expect: 100 continue #94

nick4fake opened this issue Jun 7, 2017 · 2 comments

Comments

@nick4fake
Copy link

Now when we support Transfer-Encoding: chunked it would be great to have at least basic continue support. I'll file example MR soon

@clue
Copy link
Member

clue commented Jun 7, 2017

Yes, please 👍

Self-quoting from our server-side implementation: reactphp/http#109 (comment)

Thanks for filing this ticket and sparking the discussion about our expect-continue feature (Expect: 100-continue) 👍

First things first, here's how this works in the first place:

  • This feature is specified as part of HTTP/1.1: https://tools.ietf.org/html/rfc7231#section-5.1.1
  • Clients MAY implement this feature but are not required to do so
  • Severs MAY implement this feature but are not required to do so
  • If the client includes a Expect: 100-continue header, the server MAY return an intermediary HTTP/1.1 100 Continue response after receiving the request headers, which causes the client to start transmitting the actual message body
  • If the client includes a Expect: 100-continue header, the server MAY reject the request with any "normal" error response message, which means the client never has to transmit the message body at all
  • Clients MUST support servers that do not implement this feature. This usually adds a few seconds of delay where the client waits for the intermediary HTTP/1.1 100 Continue response
  • Many common clients actually implement this feature when sending large requests only (usually a few KiB or MiB)

This means that it makes sense to automatically use this for certain requests, but we should probably provide an option to turn this off.

@clue clue added this to the v0.6.0 milestone Feb 6, 2018
@clue clue removed this from the v0.6.0 milestone Jul 12, 2020
@clue
Copy link
Member

clue commented Jul 12, 2020

Again thanks for bringing this up! I have to close this one as per #152 now that future development will focus on https://github.com/reactphp/http instead.

I've migrated the feature request to reactphp/http#378.

@clue clue closed this as completed Jul 12, 2020
@clue clue added this to the v0.6.0 milestone Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants