Support PHP 8 and add non-blocking I/O support on Windows with PHP 8 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to work around legacy HHVM which doesn't report pipe open mode. All tests pass now, so this is ready for review |
WyriHaximus
approved these changes
Jan 31, 2021
jsor
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds PHP 8 support and support for socket pair descriptors.
The socket pair descriptors are supported as of PHP 8 and provide native, non-blocking I/O support on Windows without any fancy workarounds. The PHP documentation doesn't currently reflect this features, but it's available in the upgrade guide here: https://www.php.net/manual/en/migration80.new-features.php
This changeset includes relevant tests, documentation and examples. In a follow-up PR I'll look into making socket pair descriptors the default for Windows, to make sure this works out-of-the-box on any platform. Explicit configuration will always remain available.
Builds on top of #84, #82, #67 and #65