Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection: keep-alive with Transfer-Encoding: chunked broken #265

Closed
joshiste opened this issue Jan 30, 2018 · 7 comments
Closed

Connection: keep-alive with Transfer-Encoding: chunked broken #265

joshiste opened this issue Jan 30, 2018 · 7 comments
Labels
for/user-attention This issue needs user attention (feedback, rework, etc...)

Comments

@joshiste
Copy link

joshiste commented Jan 30, 2018

It looks to me as if the chunked encoding in combination with keep-alive is broken using reactor-netty 0.7.3.

If this is not a reactor-netty issue but spring or spring boot, please let me know.

Sample steps to reproduce:
checkout https://github.com/joshiste/reactor-netty-issue
and run mvn spring-boot:run

run requests with keep-alive: ab -n10 -l -c1 -k http://localhost:8080/ --> broken
run request without keep-alive: ab -n10 -l -c1 http://localhost:8080/ --> works

The exact dependency-versions are in dependencies.txt

same example using tomcat works like a charm...

@joshiste joshiste changed the title Connection: keep-alive with Transfer-Encoding: chunked seems broken Connection: keep-alive with Transfer-Encoding: chunked broken Jan 30, 2018
@violetagg violetagg added the status/duplicate This is a duplicate of another issue label Jan 30, 2018
@violetagg
Copy link
Member

violetagg commented Jan 30, 2018

Hi,

The issue here is that ab uses HTTP 1.0
#21 we need to introduce proper support for HTTP 1.0

As a workaround try to use wrk/wrk2 or other tool that supports HTTP 1.1

Regards,
Violeta

@joshiste
Copy link
Author

I'm experiencing the same issue when using chrome!

@violetagg
Copy link
Member

violetagg commented Jan 30, 2018

What are the steps that you follow when requesting via Chrome?
Chrome version?

@violetagg violetagg reopened this Jan 30, 2018
@joshiste
Copy link
Author

Hmm I've a more complex application doing background fetches and after the fifth request the response just contains the headers and body is missing (figured out using tcpdump). When I set a Connection: close header everything is working...

@violetagg
Copy link
Member

Can you provide some example?

@violetagg violetagg added for/user-attention This issue needs user attention (feedback, rework, etc...) and removed status/duplicate This is a duplicate of another issue labels Feb 1, 2018
@joshiste
Copy link
Author

joshiste commented Feb 3, 2018

yeah I try to throw sth together up this weekend

@violetagg
Copy link
Member

I'm closing this one, if you can provide reproducible example you can reopen the issue.

Regards,
Violeta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for/user-attention This issue needs user attention (feedback, rework, etc...)
Projects
None yet
Development

No branches or pull requests

2 participants