-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eslint-plugin-react-hooks release numbering in "Releases" tab #2352
Comments
We might want to add |
But also this page I screenshot should be fixed. |
Curious, why does this matter? |
Because you wouldn't be able to easy find the release notes for a particular eslint-plugin-react-hooks version (and vice versa) |
Yeah that’s fair. We should do better with this. |
Just chiming in... just saw major release 3.0.0 come through and I am trying to find some release notes so I know what the breaking changes are. |
I agree that these packages should have their own changelog. In the meantime, for eslint-plugin-react-hooks, you can look at the history for the directory of the plugin source code here (there seem to be no breaking changes): |
Yeah looking at the commit history in the package folder is the easiest way. I bumped the major because we cut a version that is stricter and doesn’t let you call Hooks in a class. That can cause false positives, hence a major bump. facebook/react@d3368be#diff-abcd3df96e981cf0ab8ee6fc2866953c
I think this is a reasonable suggestion because it is standalone. I’ll take a PR doing this. |
Changelog has been added here: https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md |
On https://github.com/facebook/react/releases,
eslint-plugin-react-hooks
release notes are documented, like:But the plugin has different release numbering (v2.0.1 for example) than
react
(v16.9.0). This is not reflected here in release notes.The text was updated successfully, but these errors were encountered: