Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-plugin-react-hooks release numbering in "Releases" tab #2352

Closed
croraf opened this issue Sep 17, 2019 · 9 comments
Closed

eslint-plugin-react-hooks release numbering in "Releases" tab #2352

croraf opened this issue Sep 17, 2019 · 9 comments

Comments

@croraf
Copy link

croraf commented Sep 17, 2019

On https://github.com/facebook/react/releases, eslint-plugin-react-hooks release notes are documented, like:
image

But the plugin has different release numbering (v2.0.1 for example) than react (v16.9.0). This is not reflected here in release notes.

@nickserv
Copy link
Contributor

nickserv commented Sep 17, 2019

We might want to add packages/eslint-plugin-react/CHANGELOG.md like we have in the other packages

@croraf
Copy link
Author

croraf commented Sep 17, 2019

But also this page I screenshot should be fixed.

@threepointone
Copy link
Contributor

Curious, why does this matter?

@nickserv
Copy link
Contributor

Because you wouldn't be able to easy find the release notes for a particular eslint-plugin-react-hooks version (and vice versa)

@threepointone
Copy link
Contributor

Yeah that’s fair. We should do better with this.

@gunn4r
Copy link

gunn4r commented Mar 27, 2020

Just chiming in... just saw major release 3.0.0 come through and I am trying to find some release notes so I know what the breaking changes are.

@houmark
Copy link

houmark commented Mar 27, 2020

I agree that these packages should have their own changelog.

In the meantime, for eslint-plugin-react-hooks, you can look at the history for the directory of the plugin source code here (there seem to be no breaking changes):
https://github.com/facebook/react/commits/master/packages/eslint-plugin-react-hooks

@gaearon
Copy link
Member

gaearon commented Mar 28, 2020

Yeah looking at the commit history in the package folder is the easiest way.

I bumped the major because we cut a version that is stricter and doesn’t let you call Hooks in a class. That can cause false positives, hence a major bump.

facebook/react@d3368be#diff-abcd3df96e981cf0ab8ee6fc2866953c

We might want to add packages/eslint-plugin-react/CHANGELOG.md like we have in the other packages

I think this is a reasonable suggestion because it is standalone. I’ll take a PR doing this.

@dominicfraser
Copy link

@gaearon gaearon closed this as completed May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants