Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid the deprecated usage of defaultProps #898

Open
LukasTy opened this issue Dec 29, 2023 · 2 comments
Open

Avoid the deprecated usage of defaultProps #898

LukasTy opened this issue Dec 29, 2023 · 2 comments

Comments

@LukasTy
Copy link

LukasTy commented Dec 29, 2023

What would you like improved?

The defaultProps is deprecated and its usage should be replaced with default parameters.

Resources:
@Janpot Janpot mentioned this issue Jan 2, 2024
Closed
@oliviertassinari
Copy link
Contributor

oliviertassinari commented May 4, 2024 •
edited
Loading

React 19 is removing support for .defaultProps: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops on function components.

@LukasTy
Copy link
Author

LukasTy commented May 6, 2024

Clarification: the support is being removed for function components—the case of @emotion.
As for this library, it's still using classes and the approach here seems valid. 🤷

@oliviertassinari oliviertassinari mentioned this issue Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @LukasTy