Fixed nodeRef prop type for cross-frame elements
#732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
force-pushed
the
fix/cross-frame-node-ref-prop-type
branch
from
77bec9b
to
f2d48ac
Compare
|
@koba04 I think it will pass now - if not I will come back to it some time later |
|
@Andarist Thank you for your fix! |
jquense
pushed a commit
that referenced
this pull request
May 29, 2021
## [4.4.2](v4.4.1...v4.4.2) (2021-05-29) ### Bug Fixes * `nodeRef` prop type for cross-realm elements ([#732](#732)) ([8710c01](8710c01))
|
🎉 This PR is included in version 4.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Yes! Happy to see this long-standing issue fixed :). As a side note, on MUI, we fixed it by testing prop.nodeType !== 1. |
johnfrench3
pushed a commit
to johnfrench3/transition-group-react
that referenced
this pull request
Nov 2, 2022
## [4.4.2](reactjs/react-transition-group@v4.4.1...v4.4.2) (2021-05-29) ### Bug Fixes * `nodeRef` prop type for cross-realm elements ([#732](reactjs/react-transition-group#732)) ([8710c01](reactjs/react-transition-group@8710c01))
patrickm68
added a commit
to patrickm68/react-transition-group-developer
that referenced
this pull request
Dec 1, 2022
## [4.4.2](reactjs/react-transition-group@v4.4.1...v4.4.2) (2021-05-29) ### Bug Fixes * `nodeRef` prop type for cross-realm elements ([#732](reactjs/react-transition-group#732)) ([8710c01](reactjs/react-transition-group@8710c01))
shaikdev2
pushed a commit
to shaikdev2/transition-group-react
that referenced
this pull request
Jun 9, 2023
## [4.4.2](reactjs/react-transition-group@v4.4.1...v4.4.2) (2021-05-29) ### Bug Fixes * `nodeRef` prop type for cross-realm elements ([#732](reactjs/react-transition-group#732)) ([8710c01](reactjs/react-transition-group@8710c01))
GreenCat1996
added a commit
to GreenCat1996/react-transition-group
that referenced
this pull request
Aug 1, 2023
## [4.4.2](reactjs/react-transition-group@v4.4.1...v4.4.2) (2021-05-29) ### Bug Fixes * `nodeRef` prop type for cross-realm elements ([#732](reactjs/react-transition-group#732)) ([8710c01](reactjs/react-transition-group@8710c01))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo of the problem (and the fix if you uncomment it) presented here: https://codesandbox.io/s/naughty-dan-zps3f?file=/src/App.js
Simple
instanceofchecks always fail for cross-realm checks as technically each realm gets its own, pristine, environment which includes all global constructors (such asElement)