-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure SwitchTransition component is exported #516
Ensure SwitchTransition component is exported #516
Conversation
## [4.2.1](v4.2.0...v4.2.1) (2019-07-02) ### Bug Fixes * updated SwitchTransition component to be default export and exported from index.js ([#516](#516)) ([cfd0070](cfd0070))
🎉 This PR is included in version 4.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Could you describe the symptoms of this bug before fixing it? We're trying to track down a failure in our app possibly related to react-transition-group 4.2.0. We see |
The only symptom you should have seen between 4.2.0 and 4.2.1 would be if you tried to import SwitchTransition, which isn't exported correctly in |
ok, thanks. Just to follow up, we are less sure that the error we're seeing is related to our upgrade of react-transition-group. It's possible that the transition component is just the first one to trigger a render of the error'ing code path. |
## [4.2.1](reactjs/react-transition-group@v4.2.0...v4.2.1) (2019-07-02) ### Bug Fixes * updated SwitchTransition component to be default export and exported from index.js ([#516](reactjs/react-transition-group#516)) ([cfd0070](reactjs/react-transition-group@cfd0070))
## [4.2.1](reactjs/react-transition-group@v4.2.0...v4.2.1) (2019-07-02) ### Bug Fixes * updated SwitchTransition component to be default export and exported from index.js ([#516](reactjs/react-transition-group#516)) ([cfd0070](reactjs/react-transition-group@cfd0070))
## [4.2.1](reactjs/react-transition-group@v4.2.0...v4.2.1) (2019-07-02) ### Bug Fixes * updated SwitchTransition component to be default export and exported from index.js ([#516](reactjs/react-transition-group#516)) ([cfd0070](reactjs/react-transition-group@cfd0070))
## [4.2.1](reactjs/react-transition-group@v4.2.0...v4.2.1) (2019-07-02) ### Bug Fixes * updated SwitchTransition component to be default export and exported from index.js ([#516](reactjs/react-transition-group#516)) ([cfd0070](reactjs/react-transition-group@cfd0070))
Issue:
New
SwitchTransition
component isn't exported fromsrc/index.js
and cannot be used unless imported directly.Fix:
Added export of
SwitchTransition
fromsrc/index.js
. Also updated export ofSwitchTransition
to be default export, with other exports being named exports, following the convention of the other components.