Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure SwitchTransition component is exported #516

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Ensure SwitchTransition component is exported #516

merged 1 commit into from
Jul 2, 2019

Conversation

chrisbrown-io
Copy link
Contributor

@chrisbrown-io chrisbrown-io commented Jul 2, 2019

Issue:
New SwitchTransition component isn't exported from src/index.js and cannot be used unless imported directly.

Fix:
Added export of SwitchTransition from src/index.js. Also updated export of SwitchTransition to be default export, with other exports being named exports, following the convention of the other components.

@jquense jquense merged commit cfd0070 into reactjs:master Jul 2, 2019
jquense pushed a commit that referenced this pull request Jul 2, 2019
## [4.2.1](v4.2.0...v4.2.1) (2019-07-02)

### Bug Fixes

* updated SwitchTransition component to be default export and exported from index.js ([#516](#516)) ([cfd0070](cfd0070))
@jquense
Copy link
Collaborator

jquense commented Jul 2, 2019

🎉 This PR is included in version 4.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kumar303
Copy link

kumar303 commented Jul 5, 2019

Could you describe the symptoms of this bug before fixing it? We're trying to track down a failure in our app possibly related to react-transition-group 4.2.0. We see ChunkLoadError: Loading chunk N failed.

@jquense
Copy link
Collaborator

jquense commented Jul 5, 2019

The only symptom you should have seen between 4.2.0 and 4.2.1 would be if you tried to import SwitchTransition, which isn't exported correctly in 4.2.0. If ya'll running into trouble i'd check that 4.2.0 exactly vs the previous version is causing the error. That said 4.2.0 only added a new component it really shouldn't be causing an issue in existing code!

@kumar303
Copy link

kumar303 commented Jul 8, 2019

ok, thanks. Just to follow up, we are less sure that the error we're seeing is related to our upgrade of react-transition-group. It's possible that the transition component is just the first one to trigger a render of the error'ing code path.

johnfrench3 pushed a commit to johnfrench3/transition-group-react that referenced this pull request Nov 2, 2022
## [4.2.1](reactjs/react-transition-group@v4.2.0...v4.2.1) (2019-07-02)

### Bug Fixes

* updated SwitchTransition component to be default export and exported from index.js ([#516](reactjs/react-transition-group#516)) ([cfd0070](reactjs/react-transition-group@cfd0070))
patrickm68 added a commit to patrickm68/react-transition-group-developer that referenced this pull request Dec 1, 2022
## [4.2.1](reactjs/react-transition-group@v4.2.0...v4.2.1) (2019-07-02)

### Bug Fixes

* updated SwitchTransition component to be default export and exported from index.js ([#516](reactjs/react-transition-group#516)) ([cfd0070](reactjs/react-transition-group@cfd0070))
shaikdev2 pushed a commit to shaikdev2/transition-group-react that referenced this pull request Jun 9, 2023
## [4.2.1](reactjs/react-transition-group@v4.2.0...v4.2.1) (2019-07-02)

### Bug Fixes

* updated SwitchTransition component to be default export and exported from index.js ([#516](reactjs/react-transition-group#516)) ([cfd0070](reactjs/react-transition-group@cfd0070))
GreenCat1996 added a commit to GreenCat1996/react-transition-group that referenced this pull request Aug 1, 2023
## [4.2.1](reactjs/react-transition-group@v4.2.0...v4.2.1) (2019-07-02)

### Bug Fixes

* updated SwitchTransition component to be default export and exported from index.js ([#516](reactjs/react-transition-group#516)) ([cfd0070](reactjs/react-transition-group@cfd0070))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants