Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support esm via package.json routes #488

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Conversation

TrySound
Copy link
Contributor

Ref #77

Upgraded semantic-release-alt-publish-dir to get correct module field
processing

jquense/semantic-release-alt-publish-dir@795af9d

Ref reactjs#77

Upgraded semantic-release-alt-publish-dir to get correct module field
processing

jquense/semantic-release-alt-publish-dir@795af9d
@TrySound
Copy link
Contributor Author

Same PR as previously but with fixed module field
/cc @jquense @silvenon

@taion
Copy link
Member

taion commented Apr 15, 2019

same as #455

this is fine; we'll need to note the breaking change for semver

@jquense
Copy link
Collaborator

jquense commented Apr 15, 2019

what is the breaking change again?

@TrySound
Copy link
Contributor Author

Here's a breaking change
#475

@taion
Copy link
Member

taion commented Apr 15, 2019

@jquense it's #475 (comment)

if you have a CJS module that imports the ESM build due to the inter-op, then you will actually get the ESM module this time around, which means you'll need to add the .default

@jquense jquense merged commit 6337bf5 into reactjs:master Apr 16, 2019
jquense pushed a commit that referenced this pull request Apr 16, 2019
# [4.0.0](v3.0.0...v4.0.0) (2019-04-16)

### Features

* support esm via package.json routes ([#488](#488)) ([6337bf5](6337bf5)), closes [#77](#77)

### BREAKING CHANGES

* in environments where esm is supported importing from commonjs requires explicitly adding the `.default` after `require()` when resolving to the esm build
@jquense
Copy link
Collaborator

jquense commented Apr 16, 2019

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

johnfrench3 pushed a commit to johnfrench3/transition-group-react that referenced this pull request Nov 2, 2022
# [4.0.0](reactjs/react-transition-group@v3.0.0...v4.0.0) (2019-04-16)

### Features

* support esm via package.json routes ([#488](reactjs/react-transition-group#488)) ([6337bf5](reactjs/react-transition-group@6337bf5)), closes [#77](reactjs/react-transition-group#77)

### BREAKING CHANGES

* in environments where esm is supported importing from commonjs requires explicitly adding the `.default` after `require()` when resolving to the esm build
patrickm68 added a commit to patrickm68/react-transition-group-developer that referenced this pull request Dec 1, 2022
# [4.0.0](reactjs/react-transition-group@v3.0.0...v4.0.0) (2019-04-16)

### Features

* support esm via package.json routes ([#488](reactjs/react-transition-group#488)) ([6337bf5](reactjs/react-transition-group@6337bf5)), closes [#77](reactjs/react-transition-group#77)

### BREAKING CHANGES

* in environments where esm is supported importing from commonjs requires explicitly adding the `.default` after `require()` when resolving to the esm build
shaikdev2 pushed a commit to shaikdev2/transition-group-react that referenced this pull request Jun 9, 2023
# [4.0.0](reactjs/react-transition-group@v3.0.0...v4.0.0) (2019-04-16)

### Features

* support esm via package.json routes ([#488](reactjs/react-transition-group#488)) ([6337bf5](reactjs/react-transition-group@6337bf5)), closes [#77](reactjs/react-transition-group#77)

### BREAKING CHANGES

* in environments where esm is supported importing from commonjs requires explicitly adding the `.default` after `require()` when resolving to the esm build
GreenCat1996 added a commit to GreenCat1996/react-transition-group that referenced this pull request Aug 1, 2023
# [4.0.0](reactjs/react-transition-group@v3.0.0...v4.0.0) (2019-04-16)

### Features

* support esm via package.json routes ([#488](reactjs/react-transition-group#488)) ([6337bf5](reactjs/react-transition-group@6337bf5)), closes [#77](reactjs/react-transition-group#77)

### BREAKING CHANGES

* in environments where esm is supported importing from commonjs requires explicitly adding the `.default` after `require()` when resolving to the esm build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants