fix: prevent calling setState in TransitionGroup if it has been unmou…

…nted (#435)
reactjs · Dec 10, 2018 · 6d46b69 · 6d46b69
1 parent c1787ed
commit 6d46b69
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/src/TransitionGroup.js b/src/TransitionGroup.js
@@ -104,6 +104,11 @@ class TransitionGroup extends React.Component {
 
   componentDidMount() {
     this.appeared = true
+    this.mounted = true
+  }
+
+  componentWillUnmount() {
+    this.mounted = false
   }
 
   static getDerivedStateFromProps(
@@ -127,12 +132,14 @@ class TransitionGroup extends React.Component {
       child.props.onExited(node)
     }
 
-    this.setState(state => {
-      let children = { ...state.children }
+    if (this.mounted) {
+      this.setState(state => {
+        let children = { ...state.children }
 
-      delete children[child.key]
-      return { children }
-    })
+        delete children[child.key]
+        return { children }
+      })
+    }
   }
 
   render() {