Dont set body class if isOpen not change #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionng429
added a commit
to lionng429/react-modal
that referenced
this pull request
Aug 25, 2016
)" This reverts commit 1e29e4f.
|
@khmelevskii I'm afraid I'm going to need to revert this commit. It seems that it actually breaks some tests :( I failed to run them before merging. It seems that the biggest thing it does is fails to properly execute the appropriate things when the modal has an initial render that includes the modal being open. I like the idea, but we'll need to revisit this with an alternative solution. |
claydiffrient
added a commit
that referenced
this pull request
Sep 14, 2016
This reverts commit 1e29e4f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.