-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production build throws ReferenceError. #526
Labels
Comments
kennykaye
added a commit
to kennykaye/react-modal
that referenced
this issue
Oct 7, 2017
5 tasks
diasbruno
pushed a commit
that referenced
this issue
Oct 8, 2017
It looks like this was reverted 47d0d87. This problem persists in |
Hmm, probably rebase...I'll push a fix. Thanks! |
Reapplied your commit. Releasing version |
diasbruno
pushed a commit
that referenced
this issue
Oct 14, 2017
Reapplying changes from a rebase at 47d0d87.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary:
When running react modal in production,
ModalPortal
throws aReferenceError
due to incorrectPropTypes
import.PropTypes
should be imported as a default import and not a named import.Steps to reproduce:
process.env.NODE_ENV
to "production".Expected behavior:
react-modal should not throw
ReferenceError
when initializing component.Additional notes:
See:
The text was updated successfully, but these errors were encountered: