Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail with recast >= 0.10.41 #49

Closed
danez opened this issue Jan 11, 2016 · 2 comments
Closed

Tests fail with recast >= 0.10.41 #49

danez opened this issue Jan 11, 2016 · 2 comments

Comments

@danez
Copy link
Collaborator

danez commented Jan 11, 2016

With recast >= 0.10.41 two tests are failing:

 FAIL  src/handlers/__tests__/componentDocblockHandler-test.js (11.578s)
● componentDocblockHandler › ClassDeclaration › decorators › it uses the component docblock if present
  - Expected: 'Decorator description' toBe: 'Component description'
        at Spec.eval (src/handlers/__tests__/componentDocblockHandler-test.js:124:43)
● componentDocblockHandler › ES6 named exports › Named class declaration export › decorators › it uses the component docblock if present
  - Expected: 'Decorator description' toBe: 'Component description'

I opened already an issue with recast benjamn/recast#245, but no response yet. Maybe you guys know why it changed.

@fkling
Copy link
Member

fkling commented Jan 12, 2016

There have been some changes around how decorators are printed. I guess it may also have impacted comment attachment. Whether that's a bug or intended I don't know.

@fkling
Copy link
Member

fkling commented Jan 12, 2016

Looks like a bug to me: The comments property contains the decorator comment, the leadingComments property contains the component comment: http://astexplorer.net/#/lBRfRefMun .

Could probably still fix this from my side.

@fkling fkling closed this as completed in 44777a9 Jan 12, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants