check for value before using methods #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? |
|
Hey @danez, just curious if you think this might be able to make it into a release at any point. Not sure how active this project is, but wanted to follow up in case this PR got lost in the mix of notifications. |
|
I do not know what happened to this PR. It must have fallen under the radar. I'm really sorry. It is merged now, I will backport this to 5.x and cut a release soon. |
danez
pushed a commit
that referenced
this pull request
May 28, 2022
Co-authored-by: Daniel Tschinder <[email protected]> # Conflicts: # src/__tests__/__snapshots__/main-test.js.snap # src/utils/__tests__/getTSType-test.js
danez
pushed a commit
that referenced
this pull request
May 28, 2022
Co-authored-by: Daniel Tschinder <[email protected]> # Conflicts: # src/__tests__/__snapshots__/main-test.js.snap # src/utils/__tests__/getTSType-test.js
|
No worries! Thanks for merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the best way to fix this, but I was running into this error when using using typescript with this sort of type
Check out the failing fixture for an example