Teach sort-comp to put static methods at the top #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Airbnb JavaScript style guide was recently updated to sort static methods to the tops of classes [0]. Since this codemod is designed to follow the constraints of the Airbnb style guide, I figured it would be good to update this as well. [0]: airbnb/javascript#715
cpojer
added a commit
that referenced
this pull request
Feb 26, 2016
Teach sort-comp to put static methods at the top
|
thank you! |
| } else { | ||
| matching = methodsOrder[i] === method; | ||
| // Check for static methods | ||
| if (indexes.length === 0) { |
There was a problem hiding this comment.
indexes.length has to equal zero at this point. it just initialized to empty array in the line above.
There was a problem hiding this comment.
Indeed. I decided to add the check here to make it so we don't have to change this again if we add something before it.
There was a problem hiding this comment.
Ah. What do you think of #32?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Airbnb JavaScript style guide was recently updated to sort static
methods to the tops of classes 0. Since this codemod is designed to
follow the constraints of the Airbnb style guide, I figured it would be
good to update this as well.