Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaks pure-render checks #77

Open
necolas opened this issue Jun 27, 2015 · 3 comments
Open

Breaks pure-render checks #77

necolas opened this issue Jun 27, 2015 · 3 comments

Comments

@necolas
Copy link

necolas commented Jun 27, 2015

This module generates new a11y id's every render, meaning that pure render mixin doesn't work.
@necolas necolas changed the title Break pure-render checks Breaks pure-render checks Jun 27, 2015
@RickWong RickWong mentioned this issue Jul 17, 2015
Closed
@blairanderson
Copy link

Why is this important for testing accessibility?

@EvHaus
Copy link

EvHaus commented Sep 1, 2015

It's an issue because during development performance of the application is extremely poor with react-a11y enabled. Ideally we'd like to keep react-a11y enabled always so that new warnings are immediately visible to developers.

@necolas
Copy link
Author

necolas commented Sep 1, 2015

Yeah it's important because it slows iteration speed in development and makes it hard to identify similar performance regressions not caused by react-a11y.

@alexlande alexlande mentioned this issue Sep 18, 2015
Closed
@romeovs romeovs mentioned this issue Apr 5, 2016
Merged
@romeovs romeovs mentioned this issue Apr 16, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EvHaus @necolas @blairanderson