=tck #362 blackbox 209 must issue onSubscribe before any other signal #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…any other signal
akarnokd
approved these changes
May 29, 2017
viktorklang
reviewed
May 29, 2017
| @@ -287,7 +287,16 @@ public void required_spec209_blackbox_mustBePreparedToReceiveAnOnCompleteSignalW | |||
| public void run(BlackboxTestStage stage) throws Throwable { | |||
| final Publisher<T> pub = new Publisher<T>() { | |||
| @Override | |||
| public void subscribe(Subscriber<? super T> s) { | |||
| public void subscribe(final Subscriber<? super T> s) { | |||
| s.onSubscribe(new Subscription() { | |||
There was a problem hiding this comment.
This is not a valid Subscription though :)
There was a problem hiding this comment.
Please be more helpful - what would you want it to do;
The TCK contains plenty "edgy" things, since they're designed to test a single thing only
There was a problem hiding this comment.
Absolutely, I guess what we could do is to either put in a small comment explaining why, or we could throw AssertionErrors when unsupported invocations occur, or provide a more complete implementation—if we already have any in the TCK that is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #362, the TCK violated the spec without good reason (wasn't testing for anything like that)