From eeea87a0710fb6709ca74535b9bdc79d3130e56c Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Wed, 22 Feb 2023 21:07:42 -0800 Subject: [PATCH 1/2] Fix pylint issues --- src/idom/html.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/idom/html.py b/src/idom/html.py index c3a305190..6e2a17ab8 100644 --- a/src/idom/html.py +++ b/src/idom/html.py @@ -278,8 +278,7 @@ ) -@custom_vdom_constructor -def _( +def _fragment( attributes: VdomAttributes, children: Sequence[VdomChild], key: Key | None, @@ -299,6 +298,9 @@ def _( return model +_ = custom_vdom_constructor(_fragment) + + # Dcument metadata base = make_vdom_constructor("base") head = make_vdom_constructor("head") @@ -394,8 +396,7 @@ def _( noscript = make_vdom_constructor("noscript") -@custom_vdom_constructor -def script( +def _script( attributes: VdomAttributes, children: Sequence[VdomChild], key: Key | None, @@ -440,6 +441,8 @@ def script( return model +script = custom_vdom_constructor(_script) + # Demarcating edits del_ = make_vdom_constructor("del") ins = make_vdom_constructor("ins") From ebc785e237542aa2a30679925b311292c157351a Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Thu, 23 Feb 2023 01:25:55 -0800 Subject: [PATCH 2/2] Add fixme --- src/idom/html.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/idom/html.py b/src/idom/html.py index 6e2a17ab8..622ebf0ff 100644 --- a/src/idom/html.py +++ b/src/idom/html.py @@ -298,6 +298,7 @@ def _fragment( return model +# FIXME: https://github.com/PyCQA/pylint/issues/5784 _ = custom_vdom_constructor(_fragment) @@ -441,6 +442,7 @@ def _script( return model +# FIXME: https://github.com/PyCQA/pylint/issues/5784 script = custom_vdom_constructor(_script) # Demarcating edits