Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component fallback and disconnect VDOM #545

Closed
Archmonger opened this issue Dec 12, 2021 · 2 comments
Closed

Component fallback and disconnect VDOM #545

Archmonger opened this issue Dec 12, 2021 · 2 comments
Labels
priority-1-high Should be resolved ASAP. type-feature About new capabilities

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Dec 12, 2021 •
edited
Loading

Current Situation

There currently is no convenient way of reacting to WS disconnection within components without doing so in the JavaScript websocket.onclose event.

Proposed Changes

Allow all components to have a

  • fallback=...
    • Pre-generated HTML when the initial render (client's first WS connection) couldn't occur
    • Probably only feasible to exist on a top level component
      • ex. @component(fallback=...)
    • Probably will be reliant on template tags
      • Maybe this fallback HTML is serialized as a string?
  • disconnect=...
    • Pre-generated HTML displayed in the event of a websocket disconnect

Implementation Details

See here for more details.
@Archmonger Archmonger added the flag-triage Not prioritized. label Dec 12, 2021
@rmorshea rmorshea added type-feature About new capabilities and removed flag-triage Not prioritized. labels Jan 9, 2022
@rmorshea rmorshea added this to the 2.0 milestone Jan 11, 2022
@rmorshea rmorshea added the priority-2-moderate Should be resolved on a reasonable timeline. label Jan 13, 2022
@Archmonger
Copy link
Contributor Author

Archmonger commented Mar 28, 2022 •
edited
Loading

I've expanded the concept of this one to fallback and disconnect as separate entities for flexibility.

@Archmonger Archmonger mentioned this issue Jun 13, 2022
Closed
@rmorshea rmorshea mentioned this issue Jul 6, 2022
Closed
@Archmonger Archmonger changed the title Component Fallback VDOM Component fallback and disconnect VDOM Sep 14, 2022
@Archmonger Archmonger modified the milestones: Luxury, Essential Jan 29, 2023
@rmorshea rmorshea removed this from the Essential milestone Feb 21, 2023
@Archmonger Archmonger added priority-1-high Should be resolved ASAP. and removed priority-2-moderate Should be resolved on a reasonable timeline. labels Jun 14, 2023
@Archmonger
Copy link
Contributor Author

Closing this in favor of #653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-1-high Should be resolved ASAP. type-feature About new capabilities
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmorshea @Archmonger