Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create routes type #14

Closed
Archmonger opened this issue May 10, 2023 · 3 comments
Closed

Create routes type #14

Archmonger opened this issue May 10, 2023 · 3 comments
Assignees
@Archmonger

Comments

@Archmonger
Copy link
Contributor

This function needs to match the react-router equivalent.

See #2 for more details.
@rmorshea
Copy link
Contributor

This is referred to as a router presently. Can rename though.

@Archmonger
Copy link
Contributor Author

Archmonger commented May 10, 2023 •
edited
Loading

routes and route are two different callables in react-router.

Our router seems to be equivalent to with BrowserRouter, which is the root routing node

@Archmonger Archmonger linked a pull request Jun 25, 2024 that will close this issue
Rewrite ReactPy-Router #30
Merged
4 tasks
@Archmonger Archmonger removed a link to a pull request Oct 12, 2024
Rewrite ReactPy-Router #30
Merged
4 tasks
@Archmonger Archmonger self-assigned this Oct 12, 2024
@Archmonger
Copy link
Contributor Author

Closing due to this admonition on the react router docs

If you're using a data router like createBrowserRouter it is uncommon to use this component as routes defined as part of a descendant tree cannot leverage the Data APIs available to RouterProvider apps.

@Archmonger Archmonger closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Archmonger Archmonger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmorshea @Archmonger