Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding order email rejects bad email but it's not reflected in the UI #1470

Closed
brent-hoover opened this issue Oct 5, 2016 · 1 comment · May be fixed by saurabharch/reaction#11, raindigi/reaction#82, saurabharch/reaction#12 or raindigi/reaction#89
Closed

Adding order email rejects bad email but it's not reflected in the UI #1470

brent-hoover opened this issue Oct 5, 2016 · 1 comment · May be fixed by saurabharch/reaction#11, raindigi/reaction#82, saurabharch/reaction#12 or raindigi/reaction#89
Assignees
@brent-hoover
Milestone
v0.18.0

Comments

@brent-hoover
Copy link
Collaborator

Expected behavior

If you put in a invalid email address you should get a message telling you to try again

Actual Behavior

An error in the console is thrown but nothing in the UI changes

Steps to Reproduce the Behavior

  1. Place an anonymous order
  2. In the "Hello! Add an email and receive order updates." input box put an invalid address.
  3. Observe that the UI does not change but an error is thrown in both the server and client console.
@brent-hoover brent-hoover changed the title Adding order email rejects bad email but doesn't reflect that in UI Adding order email rejects bad email but it's not reflected in the UI Oct 5, 2016
@brent-hoover brent-hoover mentioned this issue Dec 16, 2016
Merged
@ghost ghost assigned brent-hoover Dec 16, 2016
@ghost ghost added the review label Dec 16, 2016
@brent-hoover brent-hoover added this to the v0.18.0 milestone Dec 16, 2016
@brent-hoover
Copy link
Collaborator Author

Fixed via previous email work.

@ghost ghost removed the review label Jan 4, 2017
This was referenced Jul 10, 2020
Open
Open
This was referenced Jul 20, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brent-hoover brent-hoover

Labels
None yet
Projects
None yet
Milestone
v0.18.0
1 participant
@brent-hoover