fix: issue#710 Shop name not persisting on Mobile Nav #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Halton Xu <[email protected]>
nnnnat
requested review from
janus-reith,
mikemurray and
willopez
and removed request for
janus-reith
|
@janus-reith could you please review? This fixes a known issue with the logo |
Akarshit
approved these changes
Feb 15, 2021
Merged
ghost
reviewed
Mar 8, 2021
| @@ -84,7 +84,7 @@ class Header extends Component { | |||
| <AccountDropdown /> | |||
| <MiniCart /> | |||
| </Toolbar> | |||
| <NavigationMobile /> | |||
| <NavigationMobile shop={shop}/> | |||
There was a problem hiding this comment.
I saw an issue similar to this Re: sitemaps in a different project. Neither issue would get picked up by TypeScript static analysis if the project were converted. As @janus-reith mentioned in #709 a conversion may not be suitable for front-end until other repos in the org are in line with a conversion initiative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #710
Impact: minor
Type: bugfix
Issue
Description of the issue this PR is solving, why it's happening, and how to reproduce it. This may differ from the original ticket as you now have more information at your disposal.
Solution
Summarize your solution to the problem. Please include short descriptions of any solutions you tested before arriving at your final solution. This will help reviewers know why you decided to solve this problem in this particular way and will speed up the review process.
If you're solving a UIX related issue, please attach screen-caps or gifs showing how your solution differs from the issue.
Breaking changes
If you have a breaking changes, list them here, otherwise list none.
Examples of breaking changes include changing file names, moving files, deleting files, renaming functions or exports, or changes to code which might cause previous versions of Reaction or third-party code not to work as expected.
Note any work that you did to mitigate the effect of any breaking changes such as creating migrations, deprecation warnings, etc.
Testing
More detail for what each of these sections should include are available in our Contributing Docs