Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes made to address book does not reflect in UI #744

Closed
MohanNarayana opened this issue Jan 21, 2021 · 1 comment · Fixed by #747
Closed

Changes made to address book does not reflect in UI #744

MohanNarayana opened this issue Jan 21, 2021 · 1 comment · Fixed by #747
Assignees
@jrw421
Labels
bug For issues that describe a defect or regression in the released software core work For issues that track feature development work being done by core Reaction developers verified reproducible For issues that describe bugs that the core team was able to confirm

Comments

@MohanNarayana
Copy link
Contributor

Type: minor

Describe the bug
Upon adding a new address or deleting an address the changes do not reflect immediately on UI. It only takes effect after browser refresh. The changes are persisted at DB level. Deleting a pre deleted address gives an appropriate address not found GraphQL error.

To Reproduce
Steps to reproduce the behavior:

  1. On the storefront UI go to Profile - > Address Book
  2. Add or delete an address.
  3. Navigate to Orders on the same page and go back to Address Book. The list is not updated with the cahange.
  4. Navigate out of the profile page (maybe home page or cart. Explore some products). Go back to address book. The list is not updated with the cahange.
  5. Refresh the browser. The list is now updated with the cahange.

Expected behavior
The address book should refresh with the changes right after clicking save/delete.
Delete should have a delete confirmation dialogue.

Screenshots

image

Desktop (please complete the following information):

  • OS: macOS Catalina
  • Browser Chrome
  • Version 10.15.7
@MohanNarayana MohanNarayana added bug For issues that describe a defect or regression in the released software core work For issues that track feature development work being done by core Reaction developers verified reproducible For issues that describe bugs that the core team was able to confirm labels Jan 21, 2021
@jrw421
Copy link
Contributor

jrw421 commented Jan 22, 2021

Looks like #654 is related to this as well.

@jrw421 jrw421 self-assigned this Jan 22, 2021
@jrw421 jrw421 mentioned this issue Feb 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrw421 jrw421

Labels
bug For issues that describe a defect or regression in the released software core work For issues that track feature development work being done by core Reaction developers verified reproducible For issues that describe bugs that the core team was able to confirm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: changes made to address book does not reflect in UI reactioncommerce/example-storefront
2 participants
@jrw421 @MohanNarayana