-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chip component #244
Comments
Hi @arturbien, can I work on this component? This seems to be interesting and a beginner's friendly start. The thing that I have noticed is:
The things that I would like to know about the component is:
What other features will you like to have in this component? I hope these questions seem to be genuine to you. Note: It is my very initial requests so ignore any informality in the request. |
Hey @hyperloo and welcome to React95 ❤️ sorry for late response, been busy lately. First of all let's rename this component to And let's keep it simple for now. I think basic requirements would be:
As a reference see React95 Button component and Material UI's Chip component: https://material-ui.com/components/chips/#chip If you need any further help feel free to join our Slack channel (link in the docs) 💪 |
@arturbien Have a look at this PR which I made earlier. I have made it for the Tag Component. #251 Should I keep this component and create a new Chip Component. |
(See yellow buttons)
The text was updated successfully, but these errors were encountered: