New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: point node to the common js build #85

Merged

jquense merged 1 commit into main from node-exports

May 14, 2023

Member

jquense commented May 8, 2023

fixes #84 in a disappointing way


          fix: point node to the common js build

0debaed

jquense requested a review from kyletsang

May 8, 2023 21:12

e1himself commented May 9, 2023 •

edited

Loading

But there is a proper fix, which isn't that much difficult to implement.

Here's how I've fixed ESM for react-bootstrap/dom-helpers: react-bootstrap/dom-helpers#180

Once dom-helpers are fixed, the same can be applied to this repo.

kyletsang approved these changes

View reviewed changes

jquense merged commit 6731f29 into main

jquense deleted the node-exports branch

May 14, 2023 14:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet