fix: downgrade uncontrollable to 7.2.1 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do we support react 16? It's like 4 years old now. |
No reason other than we haven’t had a major version bump. Should we do a v2 now? |
|
We can...tbh I I'm not sure we actually support v16 now, or if we do it might be accidently? Actually isn't v17 the same as 16 for breaking changes? Uncontrollable probably just needed to drop v15 |
|
Yeah 16 and 17 are pretty much the same except for event delegation changes in 17. Uncontrollable should work fine in 16. |
|
Let me fix that in uncontrollable 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uncontrollablev8 requires react >= 17 but@restart/uisupports >=16